Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pixi global expose command #2030

Merged
merged 33 commits into from
Sep 24, 2024
Merged

feat: add pixi global expose command #2030

merged 33 commits into from
Sep 24, 2024
+808 −319

Conversation

nichmor
Copy link
Contributor

@nichmor nichmor commented Sep 10, 2024 •
edited by Hofer-Julian
Loading

Some missing things:

  • : public doc strings
  • : tests
  • : better errors
  • : running pixi global sync at the end

it is also should be merged after #1975 lands first

@Hofer-Julian Hofer-Julian changed the title Feat/add pixi global expose command feat: add pixi global expose command Sep 13, 2024
Hofer-Julian
Hofer-Julian reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, quick review.
Will continue with the rest of the code later

src/cli/global/expose.rs Outdated Show resolved Hide resolved
src/cli/global/expose.rs Outdated Show resolved Hide resolved
src/cli/global/expose.rs Outdated Show resolved Hide resolved
@ruben-arts ruben-arts added this to the New `pixi global` milestone Sep 19, 2024
Hofer-Julian
Hofer-Julian reviewed Sep 20, 2024
View reviewed changes
src/global/install.rs Outdated Show resolved Hide resolved
@Hofer-Julian Hofer-Julian marked this pull request as ready for review September 24, 2024 08:58
baszalmstra
baszalmstra reviewed Sep 24, 2024
View reviewed changes
src/global/project/manifest.rs Outdated Show resolved Hide resolved
src/global/project/mod.rs Outdated Show resolved Hide resolved
@Hofer-Julian Hofer-Julian merged commit c17fd80 into prefix-dev:feature/pixi-global Sep 24, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hofer-Julian Hofer-Julian Hofer-Julian left review comments

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
New `pixi global`
Development

Successfully merging this pull request may close these issues.
4 participants
@nichmor @baszalmstra @Hofer-Julian @ruben-arts